Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework startup of container processes #9200

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Rework startup of container processes #9200

wants to merge 10 commits into from

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Mar 12, 2025 •
edited
Loading

  • Reworked supervisord config files to reduce code duplication
  • No need to add new configuration files for new worker services
  • [Helm] Backend pods support overriding container arguments
  • Used 1 worker pod with 1 process for tests to reduce resource usage
  • utils -> worker_utils (changed helm and docker compose accordingly)

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@azhavoro
Copy link
Contributor Author

/check

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@azhavoro azhavoro marked this pull request as ready for review March 12, 2025 09:29
@azhavoro azhavoro requested a review from zhiltsov-max as a code owner March 12, 2025 11:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (d846281) to head (ce9d776).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #9200   +/-   ##
========================================
  Coverage    73.33%   73.34%           
========================================
  Files          449      449           
  Lines        45863    45868    +5     
  Branches      3915     3917    +2     
========================================
+ Hits         33633    33641    +8     
+ Misses       12230    12227    -3
Components Coverage Δ
cvat-ui 77.11% <ø> (+0.02%) ⬆️
cvat-server 70.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@azhavoro azhavoro requested a review from SpecLad as a code owner March 12, 2025 19:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiltsov-max zhiltsov-max Awaiting requested review from zhiltsov-max zhiltsov-max is a code owner

@SpecLad SpecLad Awaiting requested review from SpecLad SpecLad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azhavoro @codecov-commenter